new frame tool#222
Closed
yzemaze wants to merge 9 commits intobk138:masterfrom
Closed
Conversation
callbacks: fix undo for FRAME tool
yzemaze
force-pushed
the
dev_frame_tool
branch
from
9089de1 to
9908550
Compare
yzemaze
force-pushed
the
dev_frame_tool
branch
from
efbcd34 to
db97c73
Compare
Owner
|
This is probably too much of a special use case, so I won't merge this one. But thank you very much for this and your other contributions ❤️! |
Contributor
Author
|
I get it. It’s a pity though, because it works great for me and would’ve been just the start. (I’ve added counters and character/emoji-stamps, alas both relying on this PR.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a way to easier and faster highlight things. The new tool
FRAMEallows drawing predefined rectangles around the clicked location – with just one click. Rectangles don’t have perfect (sharp) outer corners on purpose as I was set on usingcairo_arcto facilitate rounded corners and drawing circles as well (radius=xlength/2).With the addition of
fillcolorthere should be many useful options, including drawing dots (circles withcolor=fillcolororsize=xlength=ylength).Due to
widthalready being in use inpaint_context_newI opted forxlength(andylengthinstead of height). I couldn’t find more descriptive terms.I decided not to change the default radius of 10 to not mess with
orthogonal.